feat(r8): Add line span expansion and outside-range fallback#86
Merged
romtsn merged 2 commits intorz/feat/r8-tests-line-number-handlingfrom Feb 16, 2026
Merged
Conversation
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
2 times, most recently
from
92b293d to
a2ff34c
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-no-line-resolution
branch
from
d5292dc to
726accb
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
a2ff34c to
b1ce9ec
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-no-line-resolution
branch
from
726accb to
9672efd
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
2 times, most recently
from
9db871a to
86ca9fb
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-no-line-resolution
branch
from
9672efd to
bc97cdb
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
86ca9fb to
b692685
Compare
loewenheim
approved these changes
Feb 13, 2026
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
b692685 to
b9b4841
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-no-line-resolution
branch
from
ecdc202 to
dfa197a
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
b9b4841 to
62ed8da
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-no-line-resolution
branch
from
dfa197a to
58326db
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
62ed8da to
0af8489
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-no-line-resolution
branch
from
58326db to
0007c72
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
0af8489 to
1951c06
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-no-line-resolution
branch
from
0007c72 to
a9ec960
Compare
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
2 times, most recently
from
d1a627a to
352028f
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Base automatically changed from
rz/fix/r8-tests-no-line-resolution
to
rz/feat/r8-tests-line-number-handling
February 16, 2026 13:00
When a base entry maps to a span of original lines (e.g., `:42:44`), expand into one frame per original line. When a frame's line falls outside all mapped ranges, fall back to class-only remapping. Fixes test_different_line_number_span_stacktrace and test_outside_line_range_stacktrace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
352028f to
b4acde2
Compare
Prevents excessive iteration from malformed mapping files where the original line range could be extremely large (up to u32::MAX). The JVM bytecode maximum line number is 65535, so any span beyond that is invalid and falls through to single-line handling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
romtsn
force-pushed
the
rz/fix/r8-tests-span-and-fallback
branch
from
74b317e to
ea0879b
Compare
romtsn
merged commit fbb94bf
into
rz/feat/r8-tests-line-number-handling
4 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:42:44), expand into one frame per original line instead of just the firstmatched_anytracking in cache iterator to prevent false fallback triggers after successful matchesFixes
test_different_line_number_span_stacktraceandtest_outside_line_range_stacktrace.Test plan
test_different_line_number_span_stacktracenow passes (was failing: 1 frame instead of 3)test_outside_line_range_stacktracenow passes (was failing: unremapped frame instead of class-only remap)test_single_line_no_line_number_stacktrace(Group F — ordering)make formatandmake lintpass🤖 Generated with Claude Code